[WFCORE-6870][WFCORE-6871][WFCORE-6876] ModuleSpecification cleanups #6053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
deps-ok
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Note that the GH status box only shows 5 CI jobs passing, but https://ci.wildfly.org/project.html?projectId=WildFlyCore_PullRequest&branch_WildFlyCore_PullRequest=pull%2F6053 show the usual larger set. IIRC I forgot to add a file in the branch before submitting this and quickly fixed that, which may have confused things. |
This comment was marked as outdated.
This comment was marked as outdated.
|
The status box doesn't show the full set of CI results. They can be seen here: All jobs pass except the one recorded in the status box (which is unrelated). |
This comment was marked as outdated.
This comment was marked as outdated.
bstansberry
changed the title
yersan
approved these changes
Jul 5, 2024
yersan
added
25.x
ready-for-merge
|
Thanks @yersan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WFCORE-6870
https://issues.redhat.com/browse/WFCORE-6871
https://issues.redhat.com/browse/WFCORE-6876
Some non-urgent housekeeping.