Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WFCORE-6866 Create ServiceDescriptor for management executor #6048

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

pferraro
Copy link
Contributor

@pferraro pferraro commented Jun 25, 2024

https://issues.redhat.com/browse/WFCORE-6866

If someone has a better idea of where to locate this service descriptor, let me know.

@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Jun 25, 2024
@wildfly-ci

This comment was marked as outdated.

@wildfly-ci

This comment was marked as outdated.

@wildfly-ci

This comment was marked as outdated.

@yersan
Copy link
Collaborator

yersan commented Jul 5, 2024

If someone has a better idea of where to locate this service descriptor, let me know.

I have no better suggestions than the Capabilities class. I understand the natural choice would be to be declared on the service value class, but for this one, Executor, is impossible.

Copy link
Collaborator

@yersan yersan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In any case, I'll wait some days more in case there is any other suggestion

@yersan yersan added 25.x ready-for-merge This PR is ready to be merged and fulfills all requirements labels Jul 8, 2024
@bstansberry
Copy link
Contributor

I don't have any better locations either.

@bstansberry bstansberry merged commit de94126 into wildfly:main Jul 9, 2024
12 checks passed
@bstansberry
Copy link
Contributor

Thanks @pferraro and @yersan

@pferraro pferraro deleted the WFCORE-6866 branch July 24, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps-ok Dependencies have been checked, and there are no significant changes ready-for-merge This PR is ready to be merged and fulfills all requirements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants