[WFCORE-6823] Don't register the Jakarta AuthConfigFactory in the host controller. #5993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
deps-ok
|
@darranl just asking, shouldn't this change be driven by the RFE that would move Jakarta Authentication to its own subsystem? |
|
The reason I am submitting this now is so the pre-requisite changes can come through without getting to the point that everything needs coordinated tag and merge activity. IMO this is an internal refactoring and is not by itself feature development and is safe to be merged independently. |
|
@yersan Actually ignore my last comment, this is just a bug fix for a bug - this is not a part of any feature development. |
|
@darranl The JIRA description could use an update then, as the 'bug' aspect is unclear. |
|
@yersan / @bstansberry I have updated the description in the issue to say it is to fix the bug, |
yersan
approved these changes
May 20, 2024
yersan
added
the
ready-for-merge
|
Thanks @darranl @bstansberry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WFCORE-6823