-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WFCORE-6808 Add capability-resolving variant of child ServiceTarget-based ServiceInstaller.Builder #5985
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
@pferraro even for simple refactorings, I would say we should have them properly tracked in a valid Jira that, in a nutshell, explains the motivation/reason of the refactor. That would help to understand the change and track it down in the future. What's your opinion about that? |
WFCORE-6808 is the motivation for relocating this implementation. I'll update the commit message to make that more explicit. |
8712bb1
to
d29d722
Compare
@pferraro WFCORE-6808 or WFCORE-6806 (linked to this PR)? there are two commits, could you fix the message on both of them? If this PR is for two Jiras I would expect:
|
There is only 1 jira - but I pasted the wrong link in the PR description. :/ Fixed. |
Core -> WildFly Preview Integration Build 13581 outcome was UNKNOWN using a merge of d29d722 |
Core -> Full Integration Build 13785 outcome was UNKNOWN using a merge of d29d722 |
Core -> Full Integration Build 13526 outcome was UNKNOWN using a merge of d29d722 |
@pferraro Would you agree by squashing both commits or adding the WFCORE-6808 Jira ID to the first commit? That would help to follow up on the changes in the future. Having a single commit without Jira ID makes finding the Jira that caused the change more difficult. We recommend that each commit has the Jira ID on its message and I think it is a good practice even for simple refactorings. |
…based ServiceInstaller.Builder
Done. |
Thanks @pferraro |
https://issues.redhat.com/browse/WFCORE-6808