[WFCORE-5169] upgraded to Apache Directory Server AM27 and Kerby #5848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
deps-ok
|
Thank you very much for working on this @istudens! Just wanted to ask if you've done a quick sanity check with IBM JDK just to make sure there are no new test failures with these changes (i.e., just to make sure the failures from WFCORE-5432 won't occur anymore with these new changes). |
|
@fjuma Nope, I missed IBM JDK. I will test it. |
|
@fjuma It looks good to me even with IBM JDK 11 (both /elytron and /testsuite/elytron tests). |
|
Thanks for confirming that @istudens! |
fjuma
approved these changes
Feb 6, 2024
|
CC @Skyllarr in case you missed the request for review |
|
Oops I missed this, reviewing now |
Skyllarr
approved these changes
Feb 12, 2024
|
@istudens Thanks! |
yersan
added
ready-for-merge
|
/retest Let's give it another try after merging the Elytron upgrade |
yersan
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/WFCORE-5169
Related Issues:
https://issues.redhat.com/browse/WFCORE-6485
https://issues.redhat.com/browse/WFCORE-5255