-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WFCORE-6103] Add org.aesh dependency for Elytron Tool #5257
Conversation
Changes in this PR should be merged to WFCORE once the Elytron contains changes from ELY-2082 |
Hello, petrberan. I'm waiting for one of the admins to verify this patch with /ok-to-test in a comment. |
@fjuma If this is ok conceptually, can you put a hold label on this and make sure whoever does the upgrade PR merges this branch in the their upgrade PR branch? Thanks. |
Thanks @bstansberry, will do. I've added the hold label. |
There has been no activity on this PR for 45 days. It will be auto-closed after 90 days. |
This PR is still active. |
There has been no activity on this PR for 45 days. It will be auto-closed after 90 days. |
This PR is still active |
There has been no activity on this PR for 45 days. It will be auto-closed after 90 days. |
This PR is still active |
Core -> WildFly Preview Integration Build 12333 outcome was FAILURE using a merge of 4c3b435 Failed tests
|
Core -> Full Integration Build 12427 outcome was FAILURE using a merge of 4c3b435 Failed tests
|
Core -> WildFly Preview Integration Build 12522 outcome was FAILURE using a merge of 4c3b435 Failed tests
|
Core -> Full Integration Build 12632 outcome was FAILURE using a merge of 4c3b435 Failed tests
|
There has been no activity on this PR for 45 days. It will be auto-closed after 90 days. |
@petrberan Please coordinate with @fjuma to get this commit included with the PR that does the upgrade that brings in https://issues.redhat.com/browse/ELY-2082. Thanks. |
/retest |
I have reopened to check CI again. I think we are ready to merge the PR to WildFly Elytron and IMO we don't need to wait for that before we merge the module update. Considering "What is the worst that could happen?" we end up with a module with a redundant dependency but if CI passes nothing more. |
https://issues.redhat.com/browse/WFCORE-6103