Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFCORE-429] Incremental redeployment (single file update) over manag… #1767

Merged
merged 1 commit into from
Sep 28, 2016
Merged

[WFCORE-429] Incremental redeployment (single file update) over manag… #1767

merged 1 commit into from
Sep 28, 2016

Conversation

mjurc
Copy link
Contributor

@mjurc mjurc commented Aug 31, 2016

…ement API

Adding DeploymentOperationsTestCase for testing hard requirements on deployment operations.

@wildfly-ci
Copy link

Can one of the admins verify this patch?

@bstansberry
Copy link
Contributor

this is ok to test

ehsavoie
ehsavoie reviewed Aug 31, 2016
View reviewed changes
...c/test/java/org/wildfly/core/test/standalone/mgmt/api/core/DeploymentOperationsTestCase.java
Path dataDir = new File(jbossBaseDir).toPath().resolve("standalone").resolve("data");
Assert.assertTrue(Files.exists(dataDir));
cleanFile(dataDir.resolve("managed-exploded").toFile());
cleanFile(new File("target/archives/" + TEST_DEPLOYMENT_NAME));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should delete the archives directory which you have created :so this should be cleanFile(new File("target", "archives"));

@bstansberry bstansberry added the fixme This PR introduces issues that must be fixed label Sep 1, 2016
@wildfly-ci
Copy link

Linux Build 4506 outcome was FAILURE using a merge of c6933a6
Summary: Tests failed: 1 (1 new), passed: 3887, ignored: 59 Build time: 00:45:08

Failed tests

org.wildfly.core.test.standalone.mgmt.api.core.DeploymentOperationsTestCase.testAddContentFailsWithoutOverwriteManagedExplodedDeployment: java.lang.AssertionError: Operation add-content over existing content in deployment with overwrite=false succeeded, should fail
    at org.wildfly.core.test.standalone.mgmt.api.core.DeploymentOperationsTestCase.testAddContentFailsWithoutOverwriteManagedExplodedDeployment(DeploymentOperationsTestCase.java:227)
------- Stdout: -------
 [0m03:42:23,654 INFO  [org.jboss.as.repository] (management-handler-thread - 3) WFLYDR0001: Content added at location /opt/buildAgent/work/4c983eca15c0017f/testsuite/standalone/target/wildfly-core/standalone/data/content/84/968146dbfafb3392498d38204d82c334bf6d06/content
 [0m [0m03:42:23,658 INFO  [org.jboss.as.repository] (management-handler-thread - 3) WFLYDR0017: Content exploded at location /opt/buildAgent/work/4c983eca15c0017f/testsuite/standalone/target/wildfly-core/standalone/data/content/83/f3e84ddf65095865a627905cbb538fd5b0d207/content
 [0m [0m03:42:23,661 INFO  [org.jboss.as.server.deployment] (MSC service thread 1-5) WFLYSRV0027: Starting deployment of "test-deployment.jar" (runtime-name: "test-deployment.jar")
 [0m [0m03:42:23,667 INFO  [stdout] (MSC service thread 1-5) Properties found
 [0m [0m03:42:23,667 INFO  [stdout] (MSC service thread 1-5) Setting test-deployment.jarService to isNew
 [0m [0m03:42:23,671 INFO  [org.jboss.as.server] (management-handler-thread - 3) WFLYSRV0010: Deployed "test-deployment.jar" (runtime-name : "test-deployment.jar")
 [0m [0m03:42:23,671 INFO  [org.jboss.as.repository] (management-handler-thread - 3) WFLYDR0002: Content removed from location /opt/buildAgent/work/4c983eca15c0017f/testsuite/standalone/target/wildfly-core/standalone/data/content/84/968146dbfafb3392498d38204d82c334bf6d06/content
 [0m [0m03:42:23,678 INFO  [org.jboss.as.repository] (management-handler-thread - 1) WFLYDR0001: Content added at location /opt/buildAgent/work/4c983eca15c0017f/testsuite/standalone/target/wildfly-core/standalone/data/content/c6/5d8583ac094c6682f3751f1d6020c43302548c/content
 [0m [0m03:42:23,681 INFO  [org.jboss.as.repository] (management-handler-thread - 1) WFLYDR0002: Content removed from location /opt/buildAgent/work/4c983eca15c0017f/testsuite/standalone/target/wildfly-core/standalone/data/content/83/f3e84ddf65095865a627905cbb538fd5b0d207/content
 [0m [0m03:42:23,685 INFO  [org.jboss.as.server.deployment] (MSC service thread 1-6) WFLYSRV0028: Stopped deployment test-deployment.jar (runtime-name: test-deployment.jar) in 1ms
 [0m [0m03:42:23,689 INFO  [org.jboss.as.repository] (management-handler-thread - 3) WFLYDR0002: Content removed from location /opt/buildAgent/work/4c983eca15c0017f/testsuite/standalone/target/wildfly-core/standalone/data/content/c6/5d8583ac094c6682f3751f1d6020c43302548c/content
 [0m [0m03:42:23,689 INFO  [org.jboss.as.server] (management-handler-thread - 3) WFLYSRV0009: Undeployed "test-deployment.jar" (runtime-name: "test-deployment.jar")
 [0m

@wildfly-ci
Copy link

Windows Build 3839 outcome was FAILURE using a merge of c6933a6
Summary: Tests failed: 1 (1 new), passed: 3887, ignored: 59 Build time: 01:12:20

Failed tests

org.wildfly.core.test.standalone.mgmt.api.core.DeploymentOperationsTestCase.testAddContentFailsWithoutOverwriteManagedExplodedDeployment: java.lang.AssertionError: Operation add-content over existing content in deployment with overwrite=false succeeded, should fail
    at org.wildfly.core.test.standalone.mgmt.api.core.DeploymentOperationsTestCase.testAddContentFailsWithoutOverwriteManagedExplodedDeployment(DeploymentOperationsTestCase.java:227)
------- Stdout: -------
12:12:40,378 INFO  [org.jboss.as.repository] (management-handler-thread - 3) WFLYDR0001: Content added at location C:\BuildAgent\work\4c983eca15c0017f\testsuite\standalone\target\wildfly-core\standalone\data\content\57\bea78066e241db401bd8a5123e2dba7e7fe10d\content
12:12:40,408 INFO  [org.jboss.as.repository] (management-handler-thread - 3) WFLYDR0017: Content exploded at location C:\BuildAgent\work\4c983eca15c0017f\testsuite\standalone\target\wildfly-core\standalone\data\content\83\f3e84ddf65095865a627905cbb538fd5b0d207\content
12:12:40,428 INFO  [org.jboss.as.server.deployment] (MSC service thread 1-2) WFLYSRV0027: Starting deployment of "test-deployment.jar" (runtime-name: "test-deployment.jar")
12:12:40,446 INFO  [stdout] (MSC service thread 1-1) Properties found

12:12:40,447 INFO  [stdout] (MSC service thread 1-1) Setting test-deployment.jarService to isNew

12:12:40,460 INFO  [org.jboss.as.server] (management-handler-thread - 3) WFLYSRV0010: Deployed "test-deployment.jar" (runtime-name : "test-deployment.jar")
12:12:40,462 INFO  [org.jboss.as.repository] (management-handler-thread - 3) WFLYDR0002: Content removed from location C:\BuildAgent\work\4c983eca15c0017f\testsuite\standalone\target\wildfly-core\standalone\data\content\57\bea78066e241db401bd8a5123e2dba7e7fe10d\content
12:12:40,501 INFO  [org.jboss.as.repository] (management-handler-thread - 1) WFLYDR0001: Content added at location C:\BuildAgent\work\4c983eca15c0017f\testsuite\standalone\target\wildfly-core\standalone\data\content\7c\49fe8dd354c7168f8131717693cd5aaec3c0af\content
12:12:40,521 INFO  [org.jboss.as.repository] (management-handler-thread - 1) WFLYDR0002: Content removed from location C:\BuildAgent\work\4c983eca15c0017f\testsuite\standalone\target\wildfly-core\standalone\data\content\83\f3e84ddf65095865a627905cbb538fd5b0d207\content
12:12:40,528 INFO  [org.jboss.as.server.deployment] (MSC service thread 1-3) WFLYSRV0028: Stopped deployment test-deployment.jar (runtime-name: test-deployment.jar) in 2ms
12:12:40,555 INFO  [org.jboss.as.repository] (management-handler-thread - 3) WFLYDR0002: Content removed from location C:\BuildAgent\work\4c983eca15c0017f\testsuite\standalone\target\wildfly-core\standalone\data\content\7c\49fe8dd354c7168f8131717693cd5aaec3c0af\content
12:12:40,556 INFO  [org.jboss.as.server] (management-handler-thread - 3) WFLYSRV0009: Undeployed "test-deployment.jar" (runtime-name: "test-deployment.jar")

@ehsavoie
Copy link
Contributor

retest this please

@mjurc
[WFCORE-429] Incremental redeployment (single file update) over manag…
af70be4 
…ement API

Adding DeploymentOperationsTestCase for testing hard requirements on deployment operations.
@wildfly-ci wildfly-ci added review-needed and removed fixme This PR introduces issues that must be fixed labels Sep 21, 2016
@bstansberry
Copy link
Contributor

@ehsavoie ok now?

@ehsavoie
Copy link
Contributor

@bstansberry it's ok to merge

@bstansberry bstansberry added ready-for-merge This PR is ready to be merged and fulfills all requirements and removed review-needed labels Sep 28, 2016
@bstansberry bstansberry merged commit b5d49ce into wildfly:master Sep 28, 2016
@mjurc mjurc deleted the WFCORE-429 branch October 6, 2016 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready-for-merge This PR is ready to be merged and fulfills all requirements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mjurc @wildfly-ci @bstansberry @ehsavoie