[ELY-2544] [ELY-2254] Provide a LoginModule compatible security realm.

[Skyllarr]

issue: https://issues.redhat.com/browse/ELY-2544

This issue is resolved on maintenance branch by backporting the issue ELY-2254 to the maintenance branch.
Upstream branch does not need any changes.

This PR is only a backporting of ELY-2254

Upstream PR: #1623

[yersan]

It looks like PR links are wrong: PR title and commit message are related to ELY-2254, however, the description is linked to ELY-2544

[Skyllarr]

Hello @yersan , this issue (ELY-2254) is meant to backport the changes of ELY-2544 to the 1.15.x maintanence branch. So the PR links are correct here

[yersan]

Hi @Skyllarr , sorry, I guess the title and Jira link in the description confused me.

this issue (ELY-2254) is meant to backport the changes of ELY-2544 to the 1.15.x maintanence branch. So the PR links are correct here.

I am not familiar with how Elytron manages its issues. On WildFly / WildFly Core we follow the rule where each PR commit, PR title, and PR Jira link match all together for each PR. Hence my confusion with this one, where the commit message and PR title use ELY-2254 but the Jira link is ELY-2544.

You mentioned this issue is ELY-2254, however, that issue is already resolved and since ELY-2544 Jira is still open, I understand that this PR is for ELY-2544. Ideally, ELY-2544 should be in the pull request sent with a link to this PR. Don't get me wrong, I am not asking to change anything now, just wanted to mention that it could confuse people outside of Elytron who are used to working on WildFly (like me :)). In any case, now I have a better picture of Jira links on EAP7-2068.

[Skyllarr]

Hi @yersan , I understand the confusion and I'm sorry about that. You're right, this issue was not linked in the ELY-2544 jira issue which was my mistake, it is now linked.

It is confusing because the ELY-2544 issue is part of a maintenance RFE where the only change needed in elytron was to backport the ELY-2254 to the maintenance branch (similar issue numbers do not help either :D ) And since this is a backport, the commit title remained ELY-2254. The upstream branch specifically does not need any elytron changes for the EAP7-2068 RFE.

I have now added both issue numbers to the PR title to make it more clear, and will also add the explanation to the Jira issue description. Thanks a lot for looking into this!

[fjuma]

@Skyllarr I just realized that this PR just backports ELY-2254, there's nothing new being introduced for ELY-2544. I'll mark my previous comments as resolved.

[darranl]

Approving as a backport, if there is anything specific to the backport we have missed let us know otherwise looks good.