Fix redirect to logoutURI #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a logout redirect uri is specified via LogoutDefinition
@OpenIdAuthenticationMechanismDefinition(
clientId = "${oidcConfig.clientId}",
providerURI = "${oidcConfig.providerUri}",
redirectURI = "${baseURL}/oidc/callback",
logout = @LogoutDefinition(
accessTokenExpiry = true,
notifyProvider = true,
identityTokenExpiry = true,
redirectURI = "${baseURL}/oidc/logout"
)
)
Then the logout URL is built as "org.jboss.resteasy.specimpl.ResteasyUriBuilderImpl@5396a321" since toString method of the UriBuilder is not guaranteed to return the URL. This might work in some implementations of UriBuilder but not when using the resteasy implementation.
A build() is missing to create a URI Object first.
The issue is also present in the upstream soteria project and should also be fixed there