[#199] default to WildFly connection configuration #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstourac
reviewed
Jan 10, 2023
core/src/main/java/org/wildfly/extras/creaper/core/online/OnlineOptions.java
Outdated
Show resolved
Hide resolved
jstourac
reviewed
Jan 10, 2023
| @@ -1125,7 +1123,7 @@ | |||
| <arquillianContainer.version>${wildfly25.arquillianContainer.version}</arquillianContainer.version> | |||
|
|
|||
| <tests.ignoredCategory>${ignoredCategory.wildfly11}</tests.ignoredCategory> | |||
| <tests.specialJvmArgs>${specialJvmArgs.wildfly}</tests.specialJvmArgs> | |||
| <tests.specialJvmArgs></tests.specialJvmArgs> | |||
There was a problem hiding this comment.
well, we could probably delete these all specialJvmArgs properties but whatever...
There was a problem hiding this comment.
let's keep it for now, if we ever need it. It might be useful for JDK17 for example.
|
LGTM, thank you - just one actual small concern regarding one comment line. |
fixes wildfly-extras#199 - switch default protocol to `http-remoting` - switch default port to 9990 - drop `creaper.wildfly` property - drop `remoting` protocol support
simkam
force-pushed
the
199-remoting-out
branch
from
bd2a232 to
995de35
Compare
jstourac
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #199
http-remotingcreaper.wildflypropertyremotingprotocol support