don't use deprecated method to create ModelControllerClient #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Already deprecated in WildFly Core 2.0.10.Final / WildFly 10. - Removed in WildFly Core 20.0.0.Beta3 / to be in WildFly 28. Also removed some legacy code for AS7 support, we dropped support for AS7 in Creaper 2.0.0-Alpha.1.
|
tests passed locally with WildFly 10 |
jstourac
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removed some legacy code for AS7 support, we dropped support for AS7 in Creaper 2.0.0-Alpha.1.
I'm running tests with WildFly 10 locally, I'll comment with results. GH Actions will test WildFly 24 (we haven't proper support for > 24 yet).