Removal of AS7 and WildFly 8/9 support #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simkam
requested changes
Oct 13, 2021
We are keeping the `creaper.wildfly` property. We are also keeping the default use of `remote` protocol with `9999` port.
Both versions are quite old and their default profile requires JDK7 to use. Since we moved to JDK8 as a minimum, let's just discard these so we can move on a bit.
|
@simkam thank you, updated |
simkam
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There may be some topic for discussion - default protocol for remoting + default port number.
I kept the default to AS7, which is
remotingand9999but in WildFly the default ishttp-remotingand9990. Reason to keep that is that I was too lazy to change this. But if you feel that we should change this behavior (including thecreaper.wildflyproperty), I shall update this MR appropriately.