Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added module-root-dir option to AddModule command #190

Merged
merged 1 commit into from
Oct 7, 2021
Merged

Added module-root-dir option to AddModule command #190

merged 1 commit into from
Oct 7, 2021

Conversation

honza-kasik
Copy link
Contributor

No description provided.

@honza-kasik honza-kasik mentioned this pull request Apr 13, 2021
Merged
@marekkopecky
Copy link
Contributor

@simkam Will you please check this PR?

simkam
simkam approved these changes Apr 13, 2021
View reviewed changes
Copy link
Collaborator

@simkam simkam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

although there are unnecessary changes, what is wrong with if without brackets? rhetorical question :-)

@simkam simkam requested a review from mnovak1 April 13, 2021 11:47
@simkam simkam merged commit b24378f into wildfly-extras:master Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simkam simkam simkam approved these changes

@mnovak1 mnovak1 Awaiting requested review from mnovak1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@honza-kasik @marekkopecky @simkam