-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Wildfly 15 - 20 versions. #185
Conversation
/** WF 15.0.x.Final */ | ||
public static final ServerVersion VERSION_9_0_0 = new ServerVersion(9, 0, 0); | ||
/** WF 16.0.x.Final, 17.0.x.Final and 18.0.x.Final */ | ||
public static final ServerVersion VERSION_10_0_0 = new ServerVersion(10, 0, 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@simkam Could you please confirm I didn't make any mistake here? I checked the version number that WildFly 16-18 returns via CLI - ls
in root dir.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is 11
really not used anywhere? In some EAP minor version perhaps? (Genuine question, I really don't know.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I didn't find it anywhere:
JBoss EAP 7.2.x
- 8.0.0
JBoss EAP 7.3.x
- 10.0.0
JBoss EAP 7.4.0.CD18
- 10.0.0
JBoss EAP 7.4.0.CD19
- 12.0.0
JBoss EAP 7.4.0.CD20
- 13.0.0
Also, changing major management version in minor server update would not be possible/allowed anyway, right?
What I find confusing is that now three WildFly versions cannot be distinguished by management version even though, there seems to be at least one change in management between WildFly 17 and WildFly 18 since new attribute /subsystem=elytron/syslog-audit-log[reconnect-attempts]
was added in the latter version. I ran into this change by accident so maybe there are even more differences. Looks like there was an issue in version number propagation...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, changing major management version in minor server update would not be possible/allowed anyway, right?
That's right, but something like that (management version change in EAP micro) already happened once :-)
What I find confusing is that now three WildFly versions cannot be distinguished by management version
Yea agree. Too bad :-( And probably a bug. Better to raise with WildFly devs, I guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, not sure whether it makes sense to raise a bug since latest WildFly final release available is 20 and beta of WildFly 21 is also available already.
I guess there is not anything we can do about this anymore anymore, or do I miss something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They might at least be able to provide some insight. Whether this was intentional, or actual bug. No, I wouldn't expect it to be fixed retroactively :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked git history of multiple branches in wildfly-core and wildfly-core-eap and version 11 really doesn't seem to be used anywhere. I'm not going to dig into it. But feel free to do so @jstourac.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I probably won't. Just for possible future reference, there are following two links in regards of upgrade from 10.0.0
to 12.0.0
:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked on chat
I think for that core release no modifications were made at all but the management version was assumed to be closely aligned with the .Final version for things like host excludes so it was left unused.
FYI @simkam