Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JournalStoreVsJdbcStoreOnlineTest fix #169

Merged
merged 1 commit into from
Nov 25, 2019
Merged

JournalStoreVsJdbcStoreOnlineTest fix #169

merged 1 commit into from
Nov 25, 2019

Conversation

ChesterSVK
Copy link

Fix for issue: #166

Use-journal-store and use-jdbc-store attributes must be set exclusively and server must be restarted for avoiding this conflict.

Fix for issue: #166

Use-journal-store and use-jdbc-store attributes must be set exclusively and server must be restarted for avoiding this conflict
@Ladicek
Copy link
Contributor

Ladicek commented Mar 27, 2018

Should we also update the commands? At least the builder could fail if both are journal store and JDBC store are to be enabled at the same time (which wouldn't help in this case), and maybe the command could even disable JDBC when enabling journal (and vice versa).

I'd be slightly concerned about no longer testing the original behavior (where the server would disable JDBC when enabling journal automatically), but that's probably the price of progress.

@olukas
Copy link
Collaborator

olukas commented Mar 28, 2018

+1 for check in builder whether only one of journal store and JDBC store is configured. However I think that disabling JDBC when enabling journal and vice versa can cause some tricky issues for users - e.g. in case when they accidentally try to configure both store - in that case I believe that just thrown Exception is better than use last configured value for store.

@ChesterSVK As I said in #166 - ChangeJdbcAttributesOnlineTest and ChangeBasicAttributesOnlineTest intermittently fail with the same failure-description. Could you please fix also those test cases as part of this PR?

@Ladicek
Copy link
Contributor

Ladicek commented Mar 28, 2018

However I think that disabling JDBC when enabling journal and vice versa can cause some tricky issues for users

Yea, should probably just document that WildFly changed behavior in this.

@olukas
Copy link
Collaborator

olukas commented May 3, 2018

@ChesterSVK Hi, is there any progress with fixing ChangeJdbcAttributesOnlineTest and ChangeBasicAttributesOnlineTest please?

@rsvoboda
Copy link
Contributor

@msve please take a look

@Ladicek can you grant rights for creaper repo to @msve ?
He is "component owner" now on eap qe side.

@msve msve requested a review from mnovak1 November 25, 2019 13:18
Copy link
Collaborator

@mnovak1 mnovak1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants