-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JournalStoreVsJdbcStoreOnlineTest fix #169
Conversation
Fix for issue: #166 Use-journal-store and use-jdbc-store attributes must be set exclusively and server must be restarted for avoiding this conflict
Should we also update the commands? At least the builder could fail if both are journal store and JDBC store are to be enabled at the same time (which wouldn't help in this case), and maybe the command could even disable JDBC when enabling journal (and vice versa). I'd be slightly concerned about no longer testing the original behavior (where the server would disable JDBC when enabling journal automatically), but that's probably the price of progress. |
+1 for check in builder whether only one of journal store and JDBC store is configured. However I think that disabling JDBC when enabling journal and vice versa can cause some tricky issues for users - e.g. in case when they accidentally try to configure both store - in that case I believe that just thrown Exception is better than use last configured value for store. @ChesterSVK As I said in #166 - |
Yea, should probably just document that WildFly changed behavior in this. |
@ChesterSVK Hi, is there any progress with fixing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix for issue: #166
Use-journal-store and use-jdbc-store attributes must be set exclusively and server must be restarted for avoiding this conflict.