Added Elytron Creaper commands #168
Conversation
| import org.wildfly.extras.creaper.core.online.operations.Values; | ||
| import org.wildfly.extras.creaper.core.online.operations.admin.Administration; | ||
|
|
||
| public abstract class AbstractAddCustom implements OnlineCommand, OfflineCommand { |
There was a problem hiding this comment.
Does it need to be public?
There was a problem hiding this comment.
This is extended by classes in different packages. I believe that DesignPatterns:FriendPackages can be use somehow, but I do not think it would be helpful here. Moreover it can be extended by some Creaper command for any Elytron custom resources in any different project in the future.
There was a problem hiding this comment.
Yea, sure, it's fine like this.
| import org.wildfly.extras.creaper.core.online.operations.Operations; | ||
| import org.wildfly.extras.creaper.core.online.operations.admin.Administration; | ||
|
|
||
| public final class AddExtensionAndSubsystem implements OnlineCommand { |
There was a problem hiding this comment.
Boooo! This should have been called AddElytron....
There was a problem hiding this comment.
+1, thanks, I will fix it; however I think whether to use AddElytronExtensionAndSubsystem or just AddElytron. WDYT?
There was a problem hiding this comment.
AddElytron sounds good to me.
| * </p> | ||
| * | ||
| */ | ||
| public class CreateServerSSLContext implements OnlineCommand { |
|
OK, I just took a look at a couple of files, looks good :-D |
olukas
force-pushed
the
elytron-squashed
branch
from
3fe6380 to
ce725d3
Compare
|
Travis CI has time limit 50 minutes for job [1]. It is exceeded after adding Elytron commands tests (yay, as mchoma said, we officially overtested Creaper :) ). I split tests execution in Travis CI to Elytron and non-Elytron tests, see .travis.yml and last Travis CI results for this PR for more details. [1] https://docs.travis-ci.com/user/customizing-the-build/#Build-Timeouts |
🤣 🤣 🤣 |
|
Failed test cases in Travis ( |
Huge PR with Elytron Creaper commands. It was developed by Martin Choma, Ondrej Kotek, Josef Cacek, Jan Tymel, Hynek Svabek and me. We made code review of every code change during development phase.
It contained about 150 commits and most commands were changed a lot of times during development (because their related resources in WildFly were changed a lot of times). Since it contains only new commands we decided that history of their development is not so relevant => we squash them into one PR.