Log creaper commands in JSON format in debug

[mchoma]

Resolves #151

It producelog output as:
INFO: Executing operation /core-service=management/security-realm=creaperSecRealm:add
JSON format:
{
"operation" : "add",
"address" : [
{
"core-service" : "management"
},
{
"security-realm" : "creaperSecRealm"
}
]
}

[mchoma]

following #153

[Ladicek]

You could have just adjusted #153, but whatever works for you :-)

[Ladicek]

Now looking at the 1st comment -- is the JSON format really multiline?

[mchoma]

Not sure, if I understand you correctly. When toJSONString(compact=false) is called, then yes operation is printed "nicely" on multiple lines.

[Ladicek]

Ah, I definitely don't want that on DEBUG level. That would be too much of a change. And if I remember correctly, you wanted that JSON for pasting into a curl invocation, so you should rather want a compact output, no?

[mchoma]

Ok. I will add then own TRACE level log entry for JSON format. I prefer compact=false, as it is more human-readable and curl is OK with it.

[Ladicek]

Ah, OK, thanks.

[Ladicek]

Oh crap, I shouldn't have merged just yet :-( What's the difference between

log.tracef("JSON format:\n%s", operation.toJSONString(false));

and

log.tracef("JSON format:%n%s", operation.getOperation().toJSONString(false));

?

Specifically, I'm thinking about \n vs. %n.

Which one is correct?

[Ladicek]

@mchoma bump

[mchoma]

%n is correct, because it is platform independent.

Should I send new PR with only that change?

[rhatlapa]

Yes please.

[Ladicek]

Absolutely, thanks.