Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log creaper commands in JSON format in debug #153

Closed
wants to merge 1 commit into from
Closed

Log creaper commands in JSON format in debug #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion core/src/main/java/org/wildfly/extras/creaper/core/online/OnlineManagementClientImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,8 @@ public void apply(Iterable<OnlineCommand> commands) throws CommandFailedExceptio
public ModelNodeResult execute(ModelNode operation) throws IOException {
checkClosed();
operation = adjustOperationForDomain.adjust(operation);
log.debugf("Executing operation %s", ModelNodeOperationToCliString.convert(operation));
log.debugf("Executing operation %s\nJSON format:\n%s", ModelNodeOperationToCliString.convert(operation),
operation.toJSONString(false));
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we should be consistent with other execute methods, I suggest to do similar update mainly for execute on Operation. Not sure whether it would make sense to have it also for execute on String for some debugging purposes, I guess not.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should absolutely be added to execute(Operation) too, yes. There's no way to do that for execute(String), though.

One idea: I'm not terribly happy about newlines in a log message, how about adding it as a second log, possibly to the TRACE level?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing. I have overlooked operation.getOperation() returns ModelNode.

Regarding newlines. I was considering both options. I have intentionally decided for this option, because of selecting JSON string. It is ensured than no unintentional character will be copied.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, Operation.getOperation gives you a ModelNode, but the entire purpose of the Operation class is to have attachments, the ModelNode doesn't contain everything. Just a notice.

I'm still not exactly fond of expanding a single-line log message to 3 lines, but I guess I can be convinced. Keep on pushing :-)

ModelNode result = client.execute(operation);
return new ModelNodeResult(result);
}
Expand Down