Commands for adding/removing infinispan caches #134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * @author Jan Martiska | ||
| */ | ||
| public abstract class AbstractAddCache implements OnlineCommand { |
There was a problem hiding this comment.
We don't do @authors in Creaper. It's visible from Git history.
Also, I don't think this class should be public.
|
All comments for Generally, nice work, the comments are all minor, I don't think this will require any additional substantial work, just stylistics. |
|
BTW, offline variants are not required. |
jmartisk
force-pushed
the
infinispan-cache-ops
branch
2 times, most recently
from
ef17619 to
7625542
Compare
|
I did the changes as you requested, I hope I didn't forget anything. |
jmartisk
force-pushed
the
infinispan-cache-ops
branch
2 times, most recently
from
cdbdcce to
2b4cfb1
Compare
jmartisk
force-pushed
the
infinispan-cache-ops
branch
from
2b4cfb1 to
d61d050
Compare
|
I've made a couple of stylistic changes myself and pushed. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds support for Double in Values and ModelNodeResult, because it is needed for some properties of distributed caches.
Offline version of commands... Ugh, maybe later, aligator.