Security realms ssl truststore commands #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yea, LGTM. Please rebase on current master. |
rhatlapa
force-pushed
the
security-realms-ssl-truststore-commands
branch
from
7e0939b to
38e601f
Compare
|
Rebased. |
|
Note this is meant as simple commands, which could be later reused in more complex commands as adding https for undertow or as part of management interface. |
|
|
||
| @Override | ||
| public AddTruststoreAuthentication build() { | ||
| if (truststorePath != null && truststorePassword == null) { |
There was a problem hiding this comment.
truststorePath is optional, for example in case of PKCS11 you dont have to specify truststorePath. Please leave just if (truststorePassword == null) { with message "truststorePassword is manadatory when defining truststore"
rhatlapa
force-pushed
the
security-realms-ssl-truststore-commands
branch
from
38e601f to
871193e
Compare
|
As there was only one minor improvement requested, I've already squashed the change. |
|
Aye, thanks @mchoma. I've briefly considered asking someone else to review, but forgot about it before I finished reading through the code. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added commands for defining truststore and keystores under security realm.