Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP transport #94

Closed
Ladicek opened this issue May 12, 2016 · 5 comments
Closed

HTTP transport #94

Ladicek opened this issue May 12, 2016 · 5 comments
Assignees
Milestone

Comments

@Ladicek
Copy link
Contributor

Ladicek commented May 12, 2016

It would be useful to have support for HTTP transport, in addition to the native management protocol. Some operations can't be performed over the HTTP transport, though -- notably, anything related to CLI (i.e., all invocations of executeCli and certain subset of invocations of execute, even if we were able to parse CLI strings). Meaning that some methods of OnlineManagementClient would throw UnsupportedOperationException with the HTTP transport when they would work perfectly fine with native protocol.

For that reason, I think that maybe HTTP transport could maybe be configured in a slightly annoying way. But maybe that doesn't make a lot of sense.

This also incorporates HTTPS, which should reuse the SSL configuration bits from #93.

@Ladicek
Copy link
Contributor Author

Ladicek commented May 17, 2016

The HTTPS part can be left for later, especially if #93 will not be available in time.

@Ladicek Ladicek added this to the 1.3.0 milestone May 18, 2016
@Ladicek
Copy link
Contributor Author

Ladicek commented May 25, 2016

Oh and FYI, I'd like to avoid adding external dependencies as much as possible. I realize that the HTTP client in JDK is a PITA, but it should be enough. Or, if we really need a library, it shouldn't have a lot of dependencies itself and should probably be <scope>provided</scope> (people typically won't use the HTTP transport, so there's no reason we should pollute their classpath).

@istraka
Copy link
Collaborator

istraka commented May 26, 2016

I am thinking about creating class like HttpModelControllerClient implementing ModeControllerClient interface (probably not all methods?). Execute method would follow jboss http management api. Implemented in Java, ofc.
Is this approach OK?

@Ladicek
Copy link
Contributor Author

Ladicek commented May 27, 2016

Hm, OK, I was thinking more of an HTTP-based implementation of OnlineManagementClient, but I guess that HttpModelControllerClient would let us have a rudimentary CLI support? Probably with a bunch of limitations, but I'd say go for it.

@Ladicek
Copy link
Contributor Author

Ladicek commented Jun 8, 2016

Fixed by #109.

@Ladicek Ladicek closed this as completed Jun 8, 2016
OndrejKotek pushed a commit to OndrejKotek/creaper that referenced this issue Jun 1, 2017
Added sasl-mechanism-selector to AddAuthenticationConfiguration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants