Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

having to always update the ManagementVersion enum is too brittle #59

Closed
Ladicek opened this issue Feb 4, 2016 · 0 comments
Closed
Assignees
Milestone

Comments

@Ladicek
Copy link
Contributor

Ladicek commented Feb 4, 2016

When referring to certain management version, commands use the ManagementVersion enum which contains all known versions. This is required so that commands can differentiate between application server releases and accomodate.

The same ManagementVersion enum is, at the same time, returned from management clients when the user asks for server version. And if the server is too new, it's "unknown" and version discovery fails with an exception. Since version discovery is performed eagerly (during management client creation), this basically prevents using older Creaper with newer server versions.

This design decision was made early and never revisited. It is now clear, in the hindsight, that it was a bad decision and must be changed.

@Ladicek Ladicek added this to the 0.9.5 milestone Feb 4, 2016
@Ladicek Ladicek self-assigned this Feb 4, 2016
olukas pushed a commit to olukas/creaper that referenced this issue Jan 26, 2017
Added DR11 changes for lproperties-realm, ldap-realm and dir-context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant