use much clearer solution with Set instead of List

wildfly-extras · Jun 21, 2016 · 3810149 · 3810149
1 parent f7e0bca
commit 3810149
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/commands/src/main/java/org/wildfly/extras/creaper/commands/auditlog/ChangeAuditLogger.java b/commands/src/main/java/org/wildfly/extras/creaper/commands/auditlog/ChangeAuditLogger.java
@@ -2,7 +2,9 @@
 
 import java.util.ArrayList;
 import java.util.Arrays;
+import java.util.HashSet;
 import java.util.List;
+import java.util.Set;
 import org.wildfly.extras.creaper.commands.foundation.offline.xml.GroovyXmlTransform;
 import org.wildfly.extras.creaper.commands.foundation.offline.xml.Subtree;
 import org.wildfly.extras.creaper.core.offline.OfflineCommand;
@@ -148,10 +150,9 @@ public Builder removeHandlers(String... handlers) {
 
         public ChangeAuditLogger build() {
             if (addHandlers != null && removeHandlers != null) {
-                List<String> auxList = new ArrayList<String>();
-                auxList.addAll(addHandlers);
-                auxList.removeAll(removeHandlers);
-                if (auxList.size() < addHandlers.size()) {
+                Set<String> intersection = new HashSet<String>(addHandlers);
+                intersection.retainAll(removeHandlers);
+                if (!intersection.isEmpty()) {
                     throw new IllegalArgumentException("handler can not be added and removed at the same time");
                 }
             }