Skip to content

Commit

Permalink
[#244] drop explicit dependency on jboss-logging
Browse files Browse the repository at this point in the history
fixes #244

It attempts to fix issue due to current dependecy situation:
* creaper has explicit dependency on jboss-logging 3.3.0.Final
* jboss-logging added new methods in 3.6.0
* wildfly-core uses new methods from jboss-logging 3.6.x since 26.0.0.Beta3 which means WildFly 34
* it results in #244

Let's bring in jboss-logging transitivitely from wildfly-core to keep version aligned.

----

Originally jboss-logging dependency was added with this commit message

```
OnlineManagementClient and OfflineManagementClient now log all commands
and operations they are performing. Operations (online only) are logged
on the DEBUG level, commands are logged on INFO. Also, commands are now
advised to provide a toString() method that is used for logging.

The logging framework that is used in Creaper is JBoss Logging, because:

1. It is not actually a logging framework, it's only a facade that delegates
   the logging work to some logging framework that appears to be used.
2. It can detect all commonly used logging frameworks (Logback, Log4j, JUL)
   and one uncommon too (JBoss LogManager).
3. Creaper already depended on it transitively. Avoiding new dependencies
   is good.
4. It has a really small and nice API.
```
  • Loading branch information
simkam committed Sep 16, 2024
1 parent 5e83615 commit 159ebb1
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 11 deletions.
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -641,7 +641,6 @@ on Creaper:

- `creaper-core`:
- `com.google.guava:guava`
- `org.jboss.logging:jboss-logging`
- `creaper-commands`:
- everything from `creaper-core`
- `org.codehaus.groovy:groovy`
Expand Down
4 changes: 0 additions & 4 deletions core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,6 @@
<groupId>org.wildfly.core</groupId>
<artifactId>wildfly-cli</artifactId>
</dependency>
<dependency>
<groupId>org.jboss.logging</groupId>
<artifactId>jboss-logging</artifactId>
</dependency>
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
Expand Down
6 changes: 0 additions & 6 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@
<version.org.jboss.arquillian>1.6.0.Final</version.org.jboss.arquillian>
<!-- EAP 7.0.0 (WildFly 10) -->
<version.org.wildfly.core.wildfly-everything>2.2.0.Final</version.org.wildfly.core.wildfly-everything>
<version.org.jboss.logging.jboss-logging>3.3.0.Final</version.org.jboss.logging.jboss-logging>
<version.org.jboss.modules.jboss-modules>2.0.3.Final</version.org.jboss.modules.jboss-modules>
<version.org.jboss.shrinkwrap>1.2.6</version.org.jboss.shrinkwrap>
<version.org.mockito.mockito-core>4.6.1</version.org.mockito.mockito-core>
Expand Down Expand Up @@ -152,11 +151,6 @@
<version>${version.org.wildfly.core.wildfly-everything}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.jboss.logging</groupId>
<artifactId>jboss-logging</artifactId>
<version>${version.org.jboss.logging.jboss-logging}</version>
</dependency>
<!--
- Somehow a dependency on a non-existing version of JBoss Modules creeps into the testsuite.
- Forcing a correct and existing version here to avoid Maven always trying to download the wrong one.
Expand Down

0 comments on commit 159ebb1

Please sign in to comment.