Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛠️ Fix T379634: Ensure Proportional Italic Font Rendering in ToC #5178

Merged
merged 3 commits into from
Jan 31, 2025

Conversation

chandra9302
Copy link
Contributor

Phabricator:
T379634

Notes

  • The issue occurs when indentation level is 1 in the Table of Contents (ToC).
  • At this level, the Subheadline font type is used, setting the font size to 15.
  • When text is styled with bold or italic, the font type switches to Georgia3, which has a font size of 20.
  • This font size mismatch causes the formatted text to appear disproportionate compared to the rest of the text.
  • The issue is not specific to a single article but affects all articles’ ToC consistently.

Test Steps

  1. Open JK Rowling article on EN Wikipedia
  2. Open Table of contents, observe titles in "Life and career" section

Screenshots/Videos

Before Fix:
Before Fix

After Fix:
After Fix

@chandra9302 chandra9302 changed the title 🛠️ Fix T379634: Ensure Proportional Italic Font Rendering in Table of… 🛠️ Fix T379634: Ensure Proportional Italic Font Rendering in ToC Jan 30, 2025
@l-olson1214 l-olson1214 self-requested a review January 30, 2025 15:29
@l-olson1214 l-olson1214 merged commit 1ebb4b1 into wikimedia:main Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants