Skip to content

Commit

Permalink
Merge "Revert "[tests] mark tests as expecte4dFailure until underlyin…
Browse files Browse the repository at this point in the history
…g issue is solved""
  • Loading branch information
jenkins-bot authored and Gerrit Code Review committed Jul 1, 2024
2 parents cd1a989 + 7d8f6b6 commit 7a28b5a
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions tests/pagegenerators_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -839,7 +839,6 @@ def _get_council_page(self):
site = self.get_site()
return pywikibot.Page(site, 'Q37470')

@unittest.expectedFailure # T368879
def test_valid_qualifiers(self):
"""Test ItemClaimFilterPageGenerator using valid qualifiers."""
qualifiers = {
Expand All @@ -850,7 +849,6 @@ def test_valid_qualifiers(self):
self._simple_claim_test('P463', self._get_council_page(), qualifiers,
True)

@unittest.expectedFailure # T368879
def test_invalid_qualifiers(self):
"""Test ItemClaimFilterPageGenerator with invalid qualifiers."""
qualifiers = {
Expand All @@ -861,7 +859,6 @@ def test_invalid_qualifiers(self):
self._simple_claim_test('P463', self._get_council_page(), qualifiers,
False)

@unittest.expectedFailure # T368879
def test_nonexisting_qualifiers(self):
"""
Test ItemClaimFilterPageGenerator on sample page.
Expand All @@ -877,21 +874,18 @@ def test_nonexisting_qualifiers(self):
self._simple_claim_test('P463', self._get_council_page(), qualifiers,
False)

@unittest.expectedFailure # T368879
def test_no_qualifiers(self):
"""Test ItemClaimFilterPageGenerator without qualifiers."""
self._simple_claim_test('P474', '+91', None, True)
self._simple_claim_test('P463', 'Q37470', None, True)
self._simple_claim_test('P1334', '28,97.4,0.1', None, True)
self._simple_claim_test('P1334', '28,96,0.01', None, False)

@unittest.expectedFailure # T368879
def test_negative_filter(self):
"""Test negative ItemClaimFilterPageGenerator."""
self._simple_claim_test('P463', 'Q37470', None, False, True)
self._simple_claim_test('P463', 'Q37471', None, True, True)

@unittest.expectedFailure # T368879
def test_item_from_page(self):
"""Test ItemPage can be obtained form Page."""
site = pywikibot.Site('en', 'wikipedia')
Expand Down Expand Up @@ -1503,7 +1497,6 @@ def test_onlyifnot(self):
self.assertIsNotNone(gen)
self.assertIsEmpty(set(gen))

@unittest.expectedFailure # T368879
def test_onlyif_qualifiers(self):
"""Test -onlyif with qualifiers."""
gf = pagegenerators.GeneratorFactory(site=self.site)
Expand Down

0 comments on commit 7a28b5a

Please sign in to comment.