-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'recommended' status to each rule as a starter #317
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #317 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 103 103
Lines 603 603
=========================================
Hits 603 603
|
How have you decided which rules are recommended? |
Gut feeling / commonality in practice of changes, mostly. Very happy to change any of them. |
Is the boolean used for anything? I'm hesitant to include this in the release without thinking about it a bit more. |
The next commit in the stack requires this commit. |
[Edit: Oh, never mind, you just opted out for now. Sure.] Wait, now you've squash-merged a different version of this commit in 8acaa2e instead? |
Now-recommended rules: - no-animate-toggle - no-animate - no-class-state - no-constructor-attributes - no-deferred - no-extend - no-fx-interval - no-global-selector - no-jquery-constructor - no-load-shorthand - no-on-ready - no-parse-html-literal - no-ready - no-sizzle - variable-pattern Fixes #249.
According to the docs:
We also have a |
Not also in general for the parent property
|
Now-recommended rules:
- no-animate-toggle
- no-animate
- no-class-state
- no-constructor-attributes
- no-deferred
- no-extend
- no-fx-interval
- no-global-selector
- no-jquery-constructor
- no-load-shorthand
- no-on-ready
- no-parse-html-literal
- no-ready
- no-sizzle
- variable-pattern
Fixes #249.