Add fixer for no-proxy

Part of #115
wikimedia · Oct 8, 2020 · 3a5cc55 · 3a5cc55
1 parent 4cbdad4
commit 3a5cc55
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 3 deletions.
diff --git a/src/rules/no-proxy.js b/src/rules/no-proxy.js
@@ -4,5 +4,23 @@ const utils = require( '../utils.js' );
 
 module.exports = utils.createUtilMethodRule(
 	'proxy',
-	'Prefer `Function#bind` to `$.proxy`'
+	'Prefer `Function#bind` to `$.proxy`',
+	{
+		fixable: 'code',
+		fix: function ( node, context, fixer ) {
+			if (
+				node.arguments.length >= 2 &&
+				node.arguments[ 1 ].type !== 'Literal'
+			) {
+				const fnText = context.getSourceCode().getText( node.arguments[ 0 ] );
+				return [
+					fixer.replaceText( node.callee, fnText + '.bind' ),
+					fixer.removeRange( [
+						node.arguments[ 0 ].range[ 0 ],
+						node.arguments[ 1 ].range[ 0 ]
+					] )
+				];
+			}
+		}
+	}
 );
diff --git a/tests/rules/no-proxy.js b/tests/rules/no-proxy.js
@@ -7,11 +7,30 @@ const error = 'Prefer Function#bind to $.proxy';
 
 const ruleTester = new RuleTester();
 ruleTester.run( 'no-proxy', rule, {
-	valid: [ 'proxy()', '"test".proxy()', '"test".proxy' ],
+	valid: [ 'proxy(fn, context)', '"test".proxy(fn, context)', '"test".proxy' ],
 	invalid: [
 		{
-			code: '$.proxy()',
+			code: '$.proxy(this.fn, context)',
+			errors: [ error ],
+			output: 'this.fn.bind(context)'
+		},
+		{
+			code: '$.proxy(fn, context, arg1, arg2)',
+			errors: [ error ],
+			output: 'fn.bind(context, arg1, arg2)'
+		},
+		{
+			code: '$.proxy(context, "fnName")',
 			errors: [ error ]
+		},
+		{
+			code: '$.proxy(context, "fnName", arg1, arg2)',
+			errors: [ error ]
+		},
+		{
+			code: '$.proxy()',
+			errors: [ error ],
+			docgen: false
 		}
 	]
 } );