Add fixer for no-size

See #115
wikimedia · Oct 12, 2019 · 34f196a · 34f196a
1 parent c9e0261
commit 34f196a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/rules/no-size.js b/rules/no-size.js
@@ -4,5 +4,9 @@ const utils = require( './utils.js' );
 
 module.exports = utils.createCollectionMethodRule(
 	'size',
-	'Prefer length to $.size'
+	'Prefer length to $.size',
+	'code',
+	function ( node, fixer ) {
+		return fixer.replaceTextRange( [ node.callee.property.start, node.end ], 'length' );
+	}
 );
diff --git a/tests/no-size.js b/tests/no-size.js
@@ -11,19 +11,23 @@ ruleTester.run( 'no-size', rule, {
 	invalid: [
 		{
 			code: '$("div").size()',
-			errors: [ { message: error, type: 'CallExpression' } ]
+			errors: [ { message: error, type: 'CallExpression' } ],
+			output: '$("div").length'
 		},
 		{
 			code: '$div.size()',
-			errors: [ { message: error, type: 'CallExpression' } ]
+			errors: [ { message: error, type: 'CallExpression' } ],
+			output: '$div.length'
 		},
 		{
 			code: '$("div").first().size()',
-			errors: [ { message: error, type: 'CallExpression' } ]
+			errors: [ { message: error, type: 'CallExpression' } ],
+			output: '$("div").first().length'
 		},
 		{
 			code: '$("div").append($("input").size())',
-			errors: [ { message: error, type: 'CallExpression' } ]
+			errors: [ { message: error, type: 'CallExpression' } ],
+			output: '$("div").append($("input").length)'
 		}
 	]
 } );