Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WikiGames: strings for main gameplay. #5257

Merged
merged 3 commits into from
Jan 24, 2025
Merged

WikiGames: strings for main gameplay. #5257

merged 3 commits into from
Jan 24, 2025

Conversation

dbrant
Copy link
Member

@dbrant dbrant commented Jan 24, 2025

These are the strings used in the main workflow of the game, prior to the final screen.

@dbrant dbrant added the Ready to merge PR passed design signoff and ready to be merged. label Jan 24, 2025
<string name="on_this_day_game_title">Introducing</string>
<string name="on_this_day_game_subtitle">Wikipedia games</string>
<string name="on_this_day_game_entry_dialog_title">Introducing</string>
<string name="on_this_day_game_entry_dialog_subtitle">Wikipedia games</string>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Williamrai I also renamed a couple of your strings to be more specific to entry_dialog. The original name of the string was on_this_day_game_title which should be the title of the game, not "Introducing".

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, thank you.

@Williamrai Williamrai merged commit 0c2fcd9 into main Jan 24, 2025
1 check passed
@Williamrai Williamrai deleted the wikigameStrings branch January 24, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge PR passed design signoff and ready to be merged.
Development

Successfully merging this pull request may close these issues.

2 participants