Fix: issue of showing the User_Talk metrics in Edit History #5248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbrant
requested changes
Jan 23, 2025
app/src/main/java/org/wikipedia/page/edithistory/EditHistoryListViewModel.kt
Outdated
Show resolved
Hide resolved
dbrant
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
This PR fixes the issue when requesting the
https://wikimedia.org/api/rest_v1/metricsendpoint for a user talk page. It looks like an unsupported namespace, and we can check if the namespace isMainto avoid breaking the layout in the Edit History list.Steps to reproduce
The following screenshots show the invisible icon was caused by the incompleted request in the view model.
