Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign Tabs screen. #4954

Merged
merged 24 commits into from
Sep 27, 2024
Merged

Redesign Tabs screen. #4954

merged 24 commits into from
Sep 27, 2024

Conversation

dbrant
Copy link
Member

@dbrant dbrant commented Sep 13, 2024

What does this do?

  • Remove dependency on an unmaintained, abandoned third-party library.
  • Use a purely standard RecyclerView to accomplish displaying tabs, complete with swiping, animations, etc.
  • Make the Tabs list more modern, and more consistent with current expectations.

Before / After:

image image

Phabricator:
https://phabricator.wikimedia.org/T339295

@dbrant dbrant requested a review from cooltey as a code owner September 13, 2024 13:45
@dbrant dbrant added Ready to merge PR passed design signoff and ready to be merged. and removed Design review labels Sep 27, 2024
cooltey
cooltey requested changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@cooltey cooltey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Just have some comments 👍

app/src/main/java/org/wikipedia/page/tabs/TabActivity.kt Outdated Show resolved Hide resolved
app/src/main/java/org/wikipedia/page/tabs/SwipeableTabTouchHelperCallback.kt Outdated Show resolved Hide resolved
app/src/main/res/layout/item_tab_contents.xml Outdated Show resolved Hide resolved
app/src/main/java/org/wikipedia/page/tabs/TabActivity.kt Outdated Show resolved Hide resolved
app/src/main/java/org/wikipedia/page/tabs/TabActivity.kt Show resolved Hide resolved
app/src/main/java/org/wikipedia/views/AutoFitRecyclerView.kt Outdated Show resolved Hide resolved
@cooltey cooltey merged commit 7878170 into main Sep 27, 2024
2 checks passed
@cooltey cooltey deleted the newTabs_design branch September 27, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cooltey cooltey cooltey requested changes

Assignees
No one assigned
Labels
Ready to merge PR passed design signoff and ready to be merged.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbrant @cooltey