Fix: do not make an API call for an empty list in getPagesForLanguageVariant() #4950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getPagesForLanguageVariant()
dbrant
pushed a commit
that referenced
this pull request
Sep 12, 2024
…Variant() (#4950) * Fix: do not make an API call for an empty list in getPagesForLanguageVariant() * Improve performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
If the
listis empty, it will still return an empty string from thejoinToString()method, which will cause an error when requesting the wikidata API call inL10nUtil.getPagesForLanguageVariant().Why is this needed?
If the
morelike:API returns an empty result, it is not necessary to go through thegetPagesForLanguageVariantprocess.