Temporary accounts.

[dbrant]

This completes the design updates for our support for temporary accounts.
(Currently the app "supports" temporary accounts under the hood, purely using our network stack, but this will add the proper designs and updated verbiage to communicate to the user when a temporary account is in effect.)

Phabricator:
https://phabricator.wikimedia.org/T348988
https://phabricator.wikimedia.org/T338502
https://phabricator.wikimedia.org/T338266
https://phabricator.wikimedia.org/T338265
https://phabricator.wikimedia.org/T338268
https://phabricator.wikimedia.org/T338503

[dbrant]

@cooltey This is now ready for merge, for real. You'll notice I added a bit of logic that actually checks whether temp accounts are enabled on the current wiki, and shows slightly different verbiage as a result.

[cooltey]

Noticed some issues:

1. When adding an article description on testwiki, after submitting and back to the article view, immediately click on the Notification bell icon (since it will have an animation), and it will show "You must be logged in" in the screen and then show the notification. Do we need to update that?

2. After submitting an article description, you will see a snackbar that says thank you, and after it is dismissed, another snackbar with an action button to go to the Suggested edits will show up. Do we need to hide it if the edit was made from a temp account?

3. Not really related to this PR, but when using a temp account to make a reply to a talk topic, the user name will not be considered as a "username" and will be considered as a page in the Special:Contributions/~[temp account username].

[dbrant]

@cooltey Good observations:

1. When adding an article description on testwiki, after submitting and back to the article view, immediately click on the Notification bell icon (since it will have an animation), and it will show "You must be logged in" in the screen and then show the notification. Do we need to update that?

Done!!

2. After submitting an article description, you will see a snackbar that says thank you, and after it is dismissed, another snackbar with an action button to go to the Suggested edits will show up. Do we need to hide it if the edit was made from a temp account?

I don't really think so, because this is our current behavior for anonymous users. Temp users should be treated the same way in this case.

3. Not really related to this PR, but when using a temp account to make a reply to a talk topic, the user name will not be considered as a "username" and will be considered as a page in the Special:Contributions/~[temp account username].

Definitely not related to this PR (This happens for "contributions" link for any user within the html of a topic). Feel free to make a task. (although this would probably be extremely tricky to build.)

[cooltey]

Hi @dbrant, thanks for the response.

I don't really think so, because this is our current behavior for anonymous users. Temp users should be treated the same way in this case.

So, do we need to update the suggested edits task screen to be available for temp account users if the accounts are created? It is still showing the login card in this build.

Definitely not related to this PR (This happens for "contributions" link for any user within the html of a topic). Feel free to make a task. (although this would probably be extremely tricky to build.)

Got it. I would prefer to create a ticket after it is released for this particular issue.

[dbrant]

So, do we need to update the suggested edits task screen to be available for temp account users if the accounts are created? It is still showing the login card in this build.

@cooltey The behavior for Suggested Edits should be the same as for anonymous users.
We want to encourage users (whether anonymous or temporary) to create a permanent account. Therefore we should still show the Login card in the Edits tab.

[cooltey]

It looks good to me now.