Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plug our own HttpClient into Metrics library. #4907

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Plug our own HttpClient into Metrics library. #4907

merged 3 commits into from
Aug 30, 2024

Conversation

dbrant
Copy link
Member

@dbrant dbrant commented Aug 30, 2024

The newest version of the Metrics library allows us to plug in our own HttpClient, so let's plug in our existing OkHttpClient that we use everywhere else.
This has at least one major benefit:

  • Because the client has a built-in Cache, it will automatically cache the stream configuration calls, and potentially save a good amount of network data.

@dbrant dbrant added the Minor Minor stuff label Aug 30, 2024
@dbrant dbrant requested a review from cooltey as a code owner August 30, 2024 14:20
@cooltey cooltey merged commit 32e475c into main Aug 30, 2024
1 check passed
@cooltey cooltey deleted the mpHttpClient branch August 30, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minor Minor stuff
Development

Successfully merging this pull request may close these issues.

2 participants