Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make regex for Phab bot more powerful. #4545

Merged
merged 8 commits into from
Mar 22, 2024
Merged

Make regex for Phab bot more powerful. #4545

merged 8 commits into from
Mar 22, 2024

Conversation

dbrant
Copy link
Member

@dbrant dbrant commented Mar 22, 2024 •
edited
Loading

This makes the regex that integrates with the Phab bot even more powerful, now supporting different types of task callouts:

  • Supports the old-style Gerrit callout: Bug: T...
  • Supports simply pasting a Phab link on its own line: https://phabricator.wikimedia.org/T12345
  • Supports the new-style convention: Phabricator: https://phabricator.wikimedia.org/T12345
  • Supports the convention in the iOS repository: **Phabricator**: https://phabricator.wikimedia.org/T12345

@dbrant dbrant added the Minor Minor stuff label Mar 22, 2024
@cooltey cooltey merged commit 676a0f5 into main Mar 22, 2024
1 check passed
@cooltey cooltey deleted the phabBotRegex branch March 22, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cooltey cooltey Awaiting requested review from cooltey cooltey is a code owner

@sharvaniharan sharvaniharan Awaiting requested review from sharvaniharan

Assignees
No one assigned
Labels
Minor Minor stuff
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbrant @cooltey