Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arv: censor username if offensive username is ticked #1946

Merged
merged 7 commits into from
Sep 6, 2024
Merged

arv: censor username if offensive username is ticked #1946

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9316ea5
Issue #1945 Implementation
Feb 21, 2024
e20df6c
why is vsc doing this
darmanilink Feb 21, 2024
6bf3708
Update twinklearv.js
darmanilink Feb 21, 2024
469cd6f
is this what the linter doesn't like?
darmanilink Feb 21, 2024
aa5dc8a
i'm sorry, please squash this
darmanilink Feb 21, 2024
851ade2
fixed, sorry
darmanilink Feb 21, 2024
6992f88
would have outputted as a double space,
darmanilink Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion modules/twinklearv.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,6 +590,7 @@ Twinkle.arv.callback.evaluate = function(e) {
// Report inappropriate username
case 'username':
types = form.getChecked('arvtype').map(Morebits.string.toLowerCaseFirstChar);
var censorUsername = types.includes('offensive'); // check if the username is marked offensive

// generate human-readable string, e.g. "misleading and promotional username"
if (types.length <= 2) {
Expand Down Expand Up @@ -640,7 +641,7 @@ Twinkle.arv.callback.evaluate = function(e) {
return;
}
uaaPage.getStatusElement().status('Adding new report...');
uaaPage.setEditSummary('Reporting [[Special:Contributions/' + uid + '|' + uid + ']].');
uaaPage.setEditSummary('Reporting ' + (censorUsername ? 'an offensive username.' : '[[Special:Contributions/' + uid + '|' + uid + ']].'));
uaaPage.setChangeTags(Twinkle.changeTags);

// Blank newline per [[Special:Permalink/996949310#Spacing]]; see also [[WP:LISTGAP]] and [[WP:INDENTGAP]]
Expand Down
Loading