New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eslint: disallow nested ternaries #1695

Merged

NovemLinguae merged 2 commits into wikimedia-gadgets:master from NovemLinguae:no-nested-ternary

Jan 22, 2023

Member

NovemLinguae commented Jan 6, 2023

Suggested in #1693

Have our linter disallow stuff like this, for readability reasons:

outerNavClass = navigation === 'mw-panel' ? 'portal' : type === 'menu' ? 'dropdown vector-menu-dropdown-noicon' : 'tabs';


          eslint: disallow nested ternaries

4edc6bf

github-actions bot added Module: block Module: morebits labels


          fix two nested ternaries

23c8717

NovemLinguae merged commit ca7dc8b into wikimedia-gadgets:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module: block Module: morebits