fix!: unexpected margins on widgets #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
iisakkirotko
force-pushed
the
12-23-fix_unexpected_margins_on_widgets
branch
from
8e5c5dd to
c0cc2b5
Compare
iisakkirotko
changed the base branch from
05-21-refactor_streamline_and_improve_applayout_api
to
12-23-feat_change_mutation_detection_and_allow_reactive_boolean_defaults
This was referenced Dec 23, 2024
Draft
iisakkirotko
force-pushed
the
12-23-feat_change_mutation_detection_and_allow_reactive_boolean_defaults
branch
from
3a90256 to
3cdb9d4
Compare
4 tasks
iisakkirotko
force-pushed
the
12-23-feat_change_mutation_detection_and_allow_reactive_boolean_defaults
branch
from
3cdb9d4 to
03b2dcd
Compare
4 tasks
iisakkirotko
force-pushed
the
12-23-feat_change_mutation_detection_and_allow_reactive_boolean_defaults
branch
from
03b2dcd to
e925b44
Compare
This was referenced Jan 20, 2025
iisakkirotko
force-pushed
the
12-23-feat_change_mutation_detection_and_allow_reactive_boolean_defaults
branch
from
e925b44 to
70e86a3
Compare
4 tasks
iisakkirotko
force-pushed
the
12-23-feat_change_mutation_detection_and_allow_reactive_boolean_defaults
branch
from
70e86a3 to
31a27a8
Compare
iisakkirotko
force-pushed
the
12-23-fix_unexpected_margins_on_widgets
branch
from
c0cc2b5 to
0f37b08
Compare
maartenbreddels
approved these changes
Feb 4, 2025
iisakkirotko
force-pushed
the
12-23-feat_change_mutation_detection_and_allow_reactive_boolean_defaults
branch
from
31a27a8 to
f0a1b3b
Compare
iisakkirotko
force-pushed
the
12-23-fix_unexpected_margins_on_widgets
branch
from
0f37b08 to
2772745
Compare
iisakkirotko
merged commit e03420d
into
12-23-feat_change_mutation_detection_and_allow_reactive_boolean_defaults
29 of 30 checks passed
iisakkirotko
added a commit
that referenced
this pull request
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
pre-commitprior to committing my changes (see development setup docs).Description of changes
Fixes #691.
A visually breaking change to the way widgets are rendered. By default they get a margin as determined by
--jp-widgets-margin: 2px, but I think in combination with Vuetify this is often unexpected.Overall I don't think there would be very many cases where this would be worse than the current implementation.
In the end I think the underlying issue is that ipywidgets based components are quite difficult to style, since they don't accept a style argument like we usually use.
However, I get if we prefer to stick as close as possible to vanilla jupyter widgets settings, in which case we could do one of two other things:
solara.HTML(tag='img', ...)in our Image component, as opposed toipywidgets.Image@maartenbreddels and @mariobuikhuizen (and others) feel free to offer your opinions on the matter.