Add Flash Messages #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ka8725
reviewed
Jul 18, 2024
| flashMessages.forEach(function(flashMessage) { | ||
| flashMessage.style.display = 'none'; | ||
| }); | ||
| }, 5000); |
There was a problem hiding this comment.
Let's make it simple for now without a magic. I mean no need to hide it
VladislavSokov
force-pushed
the
add-rollback-all-button
branch
from
d312aff to
e38b754
Compare
VladislavSokov
force-pushed
the
handle-errors-ui
branch
from
aabefaa to
11f72ff
Compare
|
@VladislavSokov please rebase it |
VladislavSokov
force-pushed
the
handle-errors-ui
branch
from
3f1dd3b to
2d80d6d
Compare
VladislavSokov
force-pushed
the
handle-errors-ui
branch
from
753b71e to
e7ca8a9
Compare
ka8725
reviewed
Jul 21, 2024
| @@ -51,5 +51,8 @@ | |||
| <p>No phantom migrations found.</p> | |||
| <% end %> | |||
| </div> | |||
| <% flash.each do |key, message| %> | |||
| <div class="flash <%= key %>"><%= message %></div> | |||
| <% end %> | |||
There was a problem hiding this comment.
@VladislavSokov if there are too many migrations, will the user see this message? Is it ok? Please think about users
|
@VladislavSokov also please add an issue for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #86
Closes #79