Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix phantom migration rollback failures caused by cross-branch acronyms #108

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

m-darbinyan
Copy link
Collaborator

Closes #95

Description

Phantom migration rollbacks were failing due to differences in acronym-inflection settings between branches. Rails relies on the current environment's inflector to derive class names from migration file names, leading to a mismatch when acronyms are defined inconsistently across branches.

To resolve this, the migration class name is now directly extracted from the migration file instead of relying on Rails' inflection logic. This ensures accurate class loading and successful rollbacks regardless of acronym definitions in other branches.

@ka8725 ka8725 self-requested a review December 18, 2024 09:13
@ka8725 ka8725 merged commit 30ec5ee into main Dec 18, 2024
8 checks passed
@ka8725 ka8725 deleted the issue-95-fix-phantom-migration-acronyms branch December 18, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Phantom migrations with Acronims defined in another branch don't work
2 participants