Delete rolled back phantom migration (#107)

widefix · Dec 17, 2024 · 353075a · 353075a
1 parent ff0040d
commit 353075a
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 0 deletions.
diff --git a/lib/actual_db_schema/patches/migration_context.rb b/lib/actual_db_schema/patches/migration_context.rb
@@ -86,6 +86,7 @@ def migrate(migration)
         migrator = down_migrator_for(migration)
         migrator.extend(ActualDbSchema::Patches::Migrator)
         migrator.migrate
+        File.delete(migration.filename)
       end
 
       def branch_for(version)

diff --git a/test/rake_task_secondary_test.rb b/test/rake_task_secondary_test.rb
@@ -38,6 +38,7 @@
       assert_empty TestingState.down
       utils.run_migrations
       assert_equal %i[second first], TestingState.down
+      assert_empty utils.migrated_files
     end
 
     describe "with irreversible migration" do
@@ -61,6 +62,7 @@ def down
         assert_empty ActualDbSchema.failed
         utils.run_migrations
         assert_equal(%w[20130906111513_irreversible.rb], ActualDbSchema.failed.map { |m| File.basename(m.filename) })
+        assert_equal %w[20130906111513_irreversible.rb], utils.migrated_files
       end
     end
   end
@@ -76,6 +78,7 @@ def down
         Rake::Task["db:rollback_branches:manual"].reenable
       end
       assert_equal %i[second first], TestingState.down
+      assert_empty utils.migrated_files
     end
 
     it "skips migrations if the input is 'n'" do
@@ -90,6 +93,7 @@ def down
       end
       assert_empty TestingState.down
       assert_equal %i[first second], TestingState.up
+      assert_equal %w[20130906111511_first.rb 20130906111512_second.rb], utils.migrated_files
     end
 
     describe "with irreversible migration" do
@@ -117,6 +121,7 @@ def down
         end
         assert_equal %i[second first], TestingState.down
         assert_equal(%w[20130906111513_irreversible.rb], ActualDbSchema.failed.map { |m| File.basename(m.filename) })
+        assert_equal %w[20130906111513_irreversible.rb], utils.migrated_files
       end
     end
   end

diff --git a/test/rake_task_test.rb b/test/rake_task_test.rb
@@ -37,6 +37,7 @@
       utils.run_migrations
       assert_equal %i[second first], TestingState.down
       assert_match(/\[ActualDbSchema\] Rolling back phantom migration/, TestingState.output)
+      assert_empty utils.migrated_files
     end
 
     describe "with irreversible migration" do
@@ -62,6 +63,7 @@ def down
         assert_equal(%w[20130906111513_irreversible.rb], ActualDbSchema.failed.map { |m| File.basename(m.filename) })
         assert_match(/Error encountered during rollback:/, TestingState.output)
         assert_match(/ActiveRecord::IrreversibleMigration/, TestingState.output)
+        assert_equal %w[20130906111513_irreversible.rb], utils.migrated_files
       end
     end
 
@@ -90,6 +92,7 @@ def down
         assert_match(/Try these steps to fix and move forward:/, TestingState.output)
         assert_match(/Below are the details of the problematic migrations:/, TestingState.output)
         assert_match(%r{File: tmp/migrated/20130906111510_irreversible.rb}, TestingState.output)
+        assert_equal %w[20130906111510_irreversible.rb], utils.migrated_files
       end
     end
   end
@@ -105,6 +108,7 @@ def down
         Rake::Task["db:rollback_branches:manual"].reenable
       end
       assert_equal %i[second first], TestingState.down
+      assert_empty utils.migrated_files
     end
 
     it "skips migrations if the input is 'n'" do
@@ -119,6 +123,7 @@ def down
       end
       assert_empty TestingState.down
       assert_equal %i[first second], TestingState.up
+      assert_equal %w[20130906111511_first.rb 20130906111512_second.rb], utils.migrated_files
     end
 
     describe "with irreversible migration" do
@@ -146,6 +151,7 @@ def down
         end
         assert_equal %i[second first], TestingState.down
         assert_equal(%w[20130906111513_irreversible.rb], ActualDbSchema.failed.map { |m| File.basename(m.filename) })
+        assert_equal %w[20130906111513_irreversible.rb], utils.migrated_files
       end
     end
   end

diff --git a/test/rake_tasks_all_databases_test.rb b/test/rake_tasks_all_databases_test.rb
@@ -53,6 +53,7 @@
       assert_empty TestingState.down
       utils.run_migrations
       assert_equal %i[second_primary first_primary second_secondary first_secondary], TestingState.down
+      assert_empty utils.migrated_files(TestingState.db_config)
     end
 
     describe "with irreversible migration" do
@@ -82,6 +83,10 @@ def down
         utils.run_migrations
         failed = ActualDbSchema.failed.map { |m| File.basename(m.filename) }
         assert_equal(%w[20130906111513_irreversible_primary.rb 20130906111513_irreversible_secondary.rb], failed)
+        assert_equal(
+          %w[20130906111513_irreversible_primary.rb 20130906111513_irreversible_secondary.rb],
+          utils.migrated_files(TestingState.db_config)
+        )
       end
     end
   end
@@ -99,6 +104,15 @@ def down
       end
       assert_empty TestingState.down
       assert_equal %i[first_primary second_primary first_secondary second_secondary], TestingState.up
+      assert_equal(
+        %w[
+          20130906111511_first_primary.rb
+          20130906111512_second_primary.rb
+          20130906111514_first_secondary.rb
+          20130906111515_second_secondary.rb
+        ],
+        utils.migrated_files(TestingState.db_config)
+      )
     end
 
     describe "with irreversible migration" do
@@ -131,6 +145,10 @@ def down
         end
         failed = ActualDbSchema.failed.map { |m| File.basename(m.filename) }
         assert_equal(%w[20130906111513_irreversible_primary.rb 20130906111513_irreversible_secondary.rb], failed)
+        assert_equal(
+          %w[20130906111513_irreversible_primary.rb 20130906111513_irreversible_secondary.rb],
+          utils.migrated_files(TestingState.db_config)
+        )
       end
     end
   end