Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security] * - Block all non https traffic to S3 buckets #513

Merged
merged 3 commits into from
Nov 12, 2020
Merged

[Security] * - Block all non https traffic to S3 buckets #513

merged 3 commits into from
Nov 12, 2020

Conversation

michaelwittig
Copy link
Contributor

@michaelwittig michaelwittig commented Nov 11, 2020 •
edited
Loading

andreaswittig
andreaswittig approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@andreaswittig andreaswittig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@michaelwittig
Copy link
Contributor Author

@andreaswittig should we consider this a breaking change? I'm not sure if anyone is using http to access s3 buckets?

@andreaswittig
Copy link
Contributor

@michaelwittig Don't think anyone is accessing S3 via HTTP. Would not consider this a breaking change.

@michaelwittig michaelwittig merged commit cf513df into master Nov 12, 2020
@michaelwittig michaelwittig deleted the block-non-https branch November 12, 2020 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaswittig andreaswittig andreaswittig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelwittig @andreaswittig