Fix a logging #221
Merged
Fix a logging #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion Add a metrics of GitHub Apps installation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a small but important change to the logging behavior in the
scrapePendingRunsfunction within thepkg/metric/scrape_github.gofile. The change ensures that runs pending for over 30 minutes are logged with a message indicating they will be enqueued, while runs pending for less than 30 minutes are logged with a message indicating they will be ignored.Logging behavior update:
pkg/metric/scrape_github.go: Modified the log messages to provide clearer information on whether pending runs will be enqueued or ignored based on the duration they have been pending.