add docker hub ratelimit metric #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gamoutatsumi
force-pushed
the
add_docker_ratelimit
branch
3 times, most recently
from
c4ec366 to
6e3fd8b
Compare
gamoutatsumi
force-pushed
the
add_docker_ratelimit
branch
from
6e3fd8b to
2f81c3c
Compare
|
Please add an options that user for docker hub |
whywaita
reviewed
Sep 9, 2024
| if os.Getenv(EnvDockerHubUsername) != "" && os.Getenv(EnvDockerHubPassword) != "" { | ||
| c.DockerHubCredential.Username = os.Getenv(EnvDockerHubUsername) | ||
| c.DockerHubCredential.Password = os.Getenv(EnvDockerHubPassword) | ||
| } |
There was a problem hiding this comment.
Please logging and handling
- if set EnvProvideDockerHubMetrics is false, but set Docker credential (maybe not needed)
- if set EnvProvideDockerHubMetrics is true, but not set Docker credential (logging anonymous mode)
There was a problem hiding this comment.
thanks, reflected your reviews.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
provide docker hub ratelimit as a metric
https://docs.docker.com/docker-hub/download-rate-limit/#how-can-i-check-my-current-rate