gen: custom marshaler #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
reviewed
Dec 10, 2023
| @@ -1305,6 +1376,10 @@ func emptyValForField(f Field) (string, error) { | |||
| } | |||
| } | |||
|
|
|||
| type Marshaler interface { | |||
| MarshalCBOR() ([]byte, error) | |||
There was a problem hiding this comment.
Any reason to introduce a new interface instead of using the current MarshalCBOR(w io.Writer) error one?
| @@ -1442,6 +1524,10 @@ func emitCborMarshalStructMap(w io.Writer, gti *GenTypeInfo) error { | |||
| return nil | |||
| } | |||
|
|
|||
| type Unmarshaler interface { | |||
| UnmarshalCBOR([]byte) error | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom marshaler support on codegen using reflect's interface implementation check. Ref: bluesky-social/indigo#153
The codegen now checks custom marshaler/unmarshaler implementation for the fields of struct maps and struct tuples. When present, the codegen uses the existing methods instead of generating a new one.