Add a validate function. #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is equivalent to Deferred.UnmarshalCBOR, just more efficient because it doesn't copy.
Stebalien
added a commit
to filecoin-project/specs-actors
that referenced
this pull request
Aug 14, 2020
This change validates CBOR whenever accepted from the user as an arbitrary byte array. Note: 1. For the multisig actor, we could _technically_ skip validating the CBOR on approval because it has already been validated on propose. But this shouldn't be that expensive. 2. We don't actually need to validate the CBOR in the cron actor. I'm happy to remove it, I just wanted to start with something paranoid and walk back from there. fixes #972 depends on whyrusleeping/cbor-gen#39
whyrusleeping
approved these changes
Aug 14, 2020
Stebalien
added a commit
to filecoin-project/specs-actors
that referenced
this pull request
Aug 14, 2020
This change validates CBOR whenever accepted from the user as an arbitrary byte array. Note: 1. For the multisig actor, we could _technically_ skip validating the CBOR on approval because it has already been validated on propose. But this shouldn't be that expensive. 2. We don't actually need to validate the CBOR in the cron actor. I'm happy to remove it, I just wanted to start with something paranoid and walk back from there. fixes #972 depends on whyrusleeping/cbor-gen#39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is equivalent to Deferred.UnmarshalCBOR, just more efficient because it doesn't copy.