Fix monitor exclusion not being applied for newly detected nodes #392
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #388
Summary
Fixes a small copy-paste typo making the
monitor_excludes
option not being used at all and themonitor_includes
option being wrongly used in theRing
router to exclude newly detected nodes instead.Details
I was having the same issue of what #388 is describing and noticed that it was caused by remote accessing nodes. When a remote shell connects to an app's node, it doesn't get excluded by the default monitor exclusions defined in:
cachex/lib/cachex/router/ring.ex
Lines 98 to 102 in e1278ac
You can see that the
rem-
values are showing up in this comment when callingCachex.Router.connected()