Possible bug in :cachex_notify event handling?

[feld]

cachex/lib/cachex/hook.ex

Lines 165 to 182 in 5b8983e

	def handle_info({:cachex_notify, {event, result}}, state) do
	case timeout() do
	nil ->
	{:ok, new_state} = handle_notify(event, result, state)
	{:noreply, new_state}
	val ->
	task =
	Task.async(fn ->
	handle_notify(event, result, state)
	end)
	case Task.yield(task, val) || Task.shutdown(task) do
	{:ok, {:ok, new_state}} -> {:noreply, state}
	nil -> {:noreply, state}
	end
	end
	end

I was trying to refactor this for a dialyzer error that seemed like it was mostly benign, but then I realized there may be a logic error here which (surprisingly) neither the compiler nor dialyzer picked up. Follow this logic:

1. timeout() returns a non-nil value
2. a Task is launched calling handle_notify/3
3. If the Task yields in time, we have the case statement
4. The task yielded a value! {:ok, {:ok, new_state}} -> {:noreply, state} ... but we returned the old state anyway just like if the Task didn't yield in time? Why?

[whitfin]

Yes, this is a bug - although like you say I highly doubt this ever affected anyone (and it dates back six years). Feel free to PR a fix!