- fix a false positive for endless method definition #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
fix_false_positive_for_endless_method_definition
branch
from
7fa7dd9 to
9dd8521
Compare
iliabylich
reviewed
Apr 20, 2021
lib/parser/ruby30.y
Outdated
| @@ -3071,7 +3071,7 @@ require 'parser' | |||
| end | |||
|
|
|||
| def endless_method_name(name_t) | |||
| if name_t[0].end_with?('=') | |||
| if !%w[== === >= <= !=].include?(name_t[0]) && name_t[0].end_with?('=') | |||
There was a problem hiding this comment.
[]= should also be in this list (and who knows what else):
> ObjectSpace.each_object(Class).flat_map(&:instance_methods).uniq.select { |mid| mid.to_s.end_with?('=') && !(mid.to_s[-2] =~ /\w/) }
=> [:===, :==, :!=, :<=, :>=, :[]=]There was a problem hiding this comment.
wait, or is it a setter? 😄
There was a problem hiding this comment.
[]= will also result in the error on MRI :-)
% ruby -ve "def []=(index, value) = 42"
ruby 3.0.1p64 (2021-04-05 revision 0fb782ee38) [x86_64-darwin19]
-e:1: setter method cannot be defined in an endless method definition
def []=(index, value) = 42
% ruby -ve "def []=(index, value) = 42"
ruby 3.1.0dev (2021-04-06T07:03:20Z master 31ba817887) [x86_64-darwin19]
-e:1: setter method cannot be defined in an endless method definition
def []=(index, value) = 42
There was a problem hiding this comment.
Oh, you're right. It's a setter, so it's an error and it's expected. I updated this PR again.
test/test_parser.rb
Outdated
| @@ -10107,6 +10107,73 @@ def test_endless_setter | |||
| SINCE_3_0) | |||
| end | |||
|
|
|||
| def test_endless_comparison_method | |||
| assert_parses( | |||
There was a problem hiding this comment.
could you rewrite it into a loop that iterates over method names please? Also, source maps are redundant here.
koic
force-pushed
the
fix_false_positive_for_endless_method_definition
branch
from
9dd8521 to
fc635a8
Compare
|
Thank you for your review. I've updated this PR. |
Fixes: whitequark#795. This PR fixes false positives that comparison methods recognizes as a setter method.
koic
force-pushed
the
fix_false_positive_for_endless_method_definition
branch
from
fc635a8 to
63fd724
Compare
koic
changed the title
iliabylich
changed the title
|
@koic Thanks! |
|
Thanks too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #795.
This PR fixes false positives that comparison methods recognizes as a setter method.